Feat: Add Spring Boot AutoConfiguration#260
Open
vitinh0z wants to merge 3 commits intospotify:masterspotify/github-java-client:masterfrom
vitinh0z:feature/spring-boot-autoconfigvitinh0z/github-java-client:feature/spring-boot-autoconfigCopy head branch name to clipboard
Open
Feat: Add Spring Boot AutoConfiguration#260vitinh0z wants to merge 3 commits intospotify:masterspotify/github-java-client:masterfrom vitinh0z:feature/spring-boot-autoconfigvitinh0z/github-java-client:feature/spring-boot-autoconfigCopy head branch name to clipboard
vitinh0z wants to merge 3 commits intospotify:masterspotify/github-java-client:masterfrom
vitinh0z:feature/spring-boot-autoconfigvitinh0z/github-java-client:feature/spring-boot-autoconfigCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Spring Boot AutoConfiguration to the library.
It automatically registers the
GithubApiModulebean when the library is used in a Spring Boot application that has Jackson on the classpath.Resolves
Closes #61
Changes
spring-boot-autoconfigure(v2.7.18 for Java 11 compatibility).GithubClientAutoConfigurationto conditionally register theGithubApiModulebean.META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports.GithubClientAutoConfigurationTestusingApplicationContextRunnerto verify the behavior.Verification
mvn clean install -DskipTestslocally -> BUILD SUCCESS.mvn testlocally -> All tests passed.