Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

added configuration option confluence_ask_user #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

fernandogargiulo1986
Copy link

This option acts similarly to confluence_ask_password but applies to confluence_server_user.

Users might want to avoid writing their username in files tracked by version control.

This is less important than not writing passwords but still useful.

Signed-off-by: Fernando Gargiulo <fernando.gargiulo@enel.com>
@jdknight
Copy link
Member

(template-like response) Changes in this pull request look to be in good state. Delays in other features in this project will result in this feature being delayed (see this comment for more details), so the expected window for this feature is planned around end-of-year (2019). Feel free to make additional changes/etc. to this pull request before the planned window. Critical changes may occur on master before this pull request is merged in -- while you are free to help synchronize features as conflicts are detected, I do mind help correcting conflicts myself when I have the opportunity to merge this change in. If you wish to review changes I may stack on this pull request set, feel free to indicate so. When the window to merge this in this pull requests occurs and changes are needed, I can stack on change and wait for your additional approval. Otherwise, I will assume I may stack changes (if needed) which is deemed best for this extension for a quicker integration into master. Labeling this pull request as "planned-end-of-year".

A quick review of this pull request include the following:

  • The change looks good. I will most likely tweak the configuration documentation for confluence_ask_user to be independent description (instead of referencing confluence_ask_password).
  • It maybe nice to adjust the input request in confluence_ask_user's use case to reflect the "default" user if one is set but an empty string is provided (i.e. input(' User [current-user-conf]: '); which is silently does with this current implementation).

@jdknight jdknight added enhancement Something that can better improve this extension planned-end-of-year labels Oct 12, 2019
Signed-off-by: Fernando Gargiulo <fernando.gargiulo@enel.com>
@fernandogargiulo1986
Copy link
Author

Changes implemented.

@jdknight jdknight added this to the 1.2 milestone Oct 26, 2019
@jdknight jdknight self-assigned this Nov 12, 2019
@jdknight jdknight changed the base branch from master to feature/ask-user November 12, 2019 02:15
@jdknight jdknight merged commit 6f24e72 into sphinx-contrib:feature/ask-user Nov 12, 2019
@jdknight
Copy link
Member

@fernandogargiulo1986, thanks for the feature change. I'll just make a tweak on a feature branch and queue it up for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something that can better improve this extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.