assets: support graceful asset names #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original asset management implementation would generate an asset name (or "key") based off its absolute path (in most cases). This is not ideal since names could be long, deal with various relative paths and more. Instead, asset names will be generated based off their detected basename value. In cases where conflicting asset names are detected, newer assets will be post-fixed with a unique numerical value (compared to other pending assets). Signed-off-by: James Knight <james.d.knight@live.com>
Now that asset management will generate more simple names/keys for files, adjusting respective tests to use the updated names. Along with this change, the sample image files used for unit testing have been modified to be more unique, to prevent internal duplicate detection from affecting test scenarios. Signed-off-by: James Knight <james.d.knight@live.com>
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original asset management implementation would generate an asset name (or "key") based off its absolute path (in most cases). This is not ideal since names could be long, deal with various relative paths and more. Instead, asset names will be generated based off their detected basename value. In cases where conflicting asset names are detected, newer assets will be post-fixed with a unique numerical value (compared to other pending assets).