Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add mail from address settings in .env file #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hardware
Copy link

@hardware hardware commented Apr 30, 2018

This pull request allow to specify a name and address that is used globally for all e-mails that are sent by Bookstack. In some mail setups, mail spoofing is denied, each user may only send with his own or his alias addresses. In this specific case, this environment variables are required.

My postfix setup rejects when the noreply address sends an email as mail@bookstackapp.com which is the default one with your docker image.

reject: RCPT from docker[x.x.x.x]: 553 5.7.1 <mail@bookstackapp.com>: Sender address rejected: not owned by user noreply@domain.tld; from=<mail@bookstackapp.com> to=<user@domain.tld> proto=ESMTP helo=<bookstack.domain.tld>

BookStack/config/mail.php#L46-L57

@hardware
Copy link
Author

Any news on this ? @solidnerd

@ssddanbrown
Copy link
Contributor

Hey @hardware,

Just as an FYI, I don't think an update to the .env file is specifically required to pass these settings into BookStack. When BookStack reads from the .env file it also should check the environment. So as long as you set MAIL_FROM and MAIL_FROM_NAME as container environment variables the values should still get passed to BookStack

@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically marked as stale because it has not had any activity for the last 30 days. It will be closed if no further activity occurs during the next 7 days. Thank you for your contributions.

@stale stale bot added the stale label May 9, 2020
@stale stale bot closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.