test: drop shellspec based tests #6217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
7c0345d to
20bc85f
Compare
03bb860 to
0ffb494
Compare
This change removes the shellspec-based smoke tests. These tests were originally added to validate high-level platform workflows. Over the past few years, our engineering practices have improved. We now have more mature monitoring for upstream APIs, making these tests redundant. The same validation is now handled by the teams who own those API endpoints. Additionally, our command-line interface (CLI) now provides much richer analytics, giving us a clearer understanding of the end-user experience for all workflows. This makes a periodically run subset of tests unnecessary. Finally, the shellspec framework is no longer maintained. To reduce complexity and cognitive overhead for all contributors, we are consolidating our testing frameworks to use Jest and Tap. These tests will not be migrated to Jest, as their purpose is already fulfilled by other systems.
0ffb494 to
791ffb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the shellspec-based smoke tests.
These tests were originally added to validate high-level
platform workflows.
Over the past few years, our engineering practices have improved.
We now have more mature monitoring for upstream APIs, making
these tests redundant. The same validation is now handled by
the teams who own those API endpoints.
Additionally, our command-line interface (CLI) now provides
much richer analytics, giving us a clearer understanding of
the end-user experience for all workflows.
This makes a periodically run subset of tests unnecessary.
Finally, the shellspec framework is no longer maintained.
To reduce complexity and cognitive overhead for all contributors,
we are consolidating our testing frameworks to use Jest and Tap.
These tests will not be migrated to Jest,
as their purpose is already fulfilled by other systems.
https://snyksec.atlassian.net/browse/CLI-1162
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?