Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new Symfony 3.4+ session handler to gain session fixation protection and avoid unnecessary writes.
This breaks compatibility with Symfony 3.3 and below so it should be included in a major version only IMO, but we are going to use it in production soon.
Note that this includes #403 as I didn't want to introduce conflicts but I can easily undo that if needed.
Also note that with this, as Symfony will only write to the session when data actually changed, locking the session becomes a lot less necessary, as you have less chances of overwriting data with outdated one. At least if you don't use the session too much this is a big win in terms of throughput and number of commands redis has to deal with.
So: