fix: Implement `flush` function on `Async` #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gabyx wants to merge 1 commit into slog-rs:master from gabyx:feature/async-flush

gabyx commented Mar 16, 2024 •

edited

Loading

See slog-rs/slog#332


          fix: Implement flush function on Async

5b3f16d

Author

gabyx commented Mar 16, 2024

Not really sure if that feature is needed: The use case was #35 :

Make the worker thread somehow stop processing records (not implemented)
Flush all pending stuff (till the crossbeam channels are empty) implemented
Output some prompt on letssay stderr.
Make the worker thread continue to process records.

So if we would have a term logger we could before prompting just use log.flush(...) and then show the prompt and wait for input etc...

Contributor

dpc commented Mar 17, 2024

Looks reasonable to me. Ping @Techcable as current maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet