when tests are green i can code review it, thanks again for contribution @svdgraaf !

after reading up on it, i am not convinced that the resource behaves as mentioned. can you @svdgraaf supply me with a request json output (aws to lambda request object) from both cases, with / without custom domain.

Hmmm, let me check and get those for you

Without custom domain (see the Host header):

{
	"resource": "/contexts",
	"path": "/contexts/",
	"httpMethod": "GET",
	"headers": {
		"Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
		"Accept-Encoding": "gzip, deflate, br",
		"Accept-Language": "en-US,en;q=0.9,nl;q=0.8",
		"cache-control": "max-age=0",
		"CloudFront-Forwarded-Proto": "https",
		"CloudFront-Is-Desktop-Viewer": "true",
		"CloudFront-Is-Mobile-Viewer": "false",
		"CloudFront-Is-SmartTV-Viewer": "false",
		"CloudFront-Is-Tablet-Viewer": "false",
		"CloudFront-Viewer-Country": "NL",
		"Host": "dil4b1[snip].execute-api.eu-west-1.amazonaws.com",
		"upgrade-insecure-requests": "1",
		"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36",
		"Via": "2.0 605e6ba1f1cba02856e68eba7a887943.cloudfront.net (CloudFront)",
		"X-Amz-Cf-Id": "1Q-QBcjKNCXV5GdnzU3z8MI8CSAeX4A0y1Un9CzryWD2fCaH1BAB1Q==",
		"X-Amzn-Trace-Id": "Root=1-5acb33b1-8e557582fb9e8fe9ecd61c7f",
		"X-Forwarded-For": "85.119.108.158, 54.240.1 [TRUNCATED]

With custom domain:
The endpoint is: https://api.tsentlz[snip].com/v2/contexts/

{
	"resource": "/contexts",
	"path": "/v2/contexts",
	"httpMethod": "GET",
	"headers": {
		"Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
		"Accept-Encoding": "gzip, deflate, br",
		"Accept-Language": "en-US,en;q=0.9,nl;q=0.8",
		"cache-control": "max-age=0",
		"CloudFront-Forwarded-Proto": "https",
		"CloudFront-Is-Desktop-Viewer": "true",
		"CloudFront-Is-Mobile-Viewer": "false",
		"CloudFront-Is-SmartTV-Viewer": "false",
		"CloudFront-Is-Tablet-Viewer": "false",
		"CloudFront-Viewer-Country": "NL",
		"Host": "api.tsentlz[snip].com",
		"upgrade-insecure-requests": "1",
		"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36",
		"Via": "2.0 e7ce333c56f455a0dae7f1f5ea5d6086.cloudfront.net (CloudFront)",
		"X-Amz-Cf-Id": "xbc76lD0RKn6DADJ6mLHaWAu8xbGFdycyF-9xRMcui17n0WJtDsBPQ==",
		"X-Amzn-Trace-Id": "Root=1-5acb33b0-4d288d542c2d8ee06ad2f014",
		"X-Forwarded-For": "85.119.108.158, 54.182.239.98",
		"X-Forwarded-Port" [TRUNCATED]

Do you have any links where you read about the resource not being correct to use? Because then we need to figure something else out to make this compatible

from what you have shown it looks like it should more be:
if not resource == path:
....path=resource

but then why not always resource instead of path?

i think what i meant with resource being weird is
"resource": "/{proxy+}",
from
http://www.1strategy.com/blog/2017/06/06/how-to-use-amazon-api-gateway-proxy/

the example shows that you can use some kind of path params in the resource field

Yeah, I think we can just default to the resource key. I'll check how that behaves when it is setup with {proxy+}, I think we can make that just default to the catchall, and forward the whole uri as path.

Ok, figured it out, and changed things accordingly. As discussed it now uses the resource key. I'm not sure if we want to fallback to path as well, but that's easy to add.

The {proxy+} is now also supported, if that is given in the event, the path parameter "proxy" contains the actual value for that part of the path. So I just replace that with the actual value, and the routing works.

I changed the readme to use resource instead of path, but as suggested above here, perhaps we want to have a fallback to path as well, if so, let me know and I'll add it. The readme can than just have path, which might look more natural for a first introduction.

great work @svdgraaf !
some questions:

1. have you tested it with APIGW? i don't currently have access.
2. can you bump the version, both in init and setup.py and write the history

(3) i think a fallback is unnecessary, the switch from path to resource should work and not convolute the code with fallbacks.

I'm currently testing it with apigw, found a bug, working on it :)

Ok, the bug was my bad :D pebkac. You can test the apigw integration here:

https://api.tsentlzwoot.com/v2/foobar/asdfsdf/asdfsdf/asdfasdf/asdfasdf/

/foobar is setup as /foobar/<path:path>, and it outputs everything it got from the {proxy+} field.