Return none and not empty string on empty body#28
Merged
sloev merged 3 commits intomastersloev/python-lambdarest:masterfrom Dec 21, 2017
return-none-and-not-empty-string-on-empty-bodysloev/python-lambdarest:return-none-and-not-empty-string-on-empty-bodyCopy head branch name to clipboard
Merged
Return none and not empty string on empty body#28sloev merged 3 commits intomastersloev/python-lambdarest:masterfrom return-none-and-not-empty-string-on-empty-bodysloev/python-lambdarest:return-none-and-not-empty-string-on-empty-bodyCopy head branch name to clipboard
sloev merged 3 commits intomastersloev/python-lambdarest:masterfrom
return-none-and-not-empty-string-on-empty-bodysloev/python-lambdarest:return-none-and-not-empty-string-on-empty-bodyCopy head branch name to clipboard
Conversation
Some endpoints require us to return `200` but also require the body to be empty. The current default results in an otherwise empty body being set to `""` which is surprising and in our case a bit unfortunate.
sloev
approved these changes
Dec 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some endpoints require us to return
200but also require the body to be empty. The current default results in an otherwise empty body being set to""which is surprising and in our case a bit unfortunate.