Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@flavioheleno
Copy link
Contributor

@flavioheleno flavioheleno commented Jul 6, 2024

$headerValue = $type;
if ($maxAge || is_integer($maxAge)) {
if (!is_integer($maxAge) && !is_null($maxAge)) {
if (!is_integer($maxAge) && $maxAge !== null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line relevant for the new version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not changed, the static analysis (performed by composer test) fails

@odan odan merged commit 7932a96 into slimphp:1.x Jul 7, 2024
@akrabat akrabat modified the milestones: 1.3.0, 1.2.0 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.