Image block cache improvement #3138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bcd42a to
2816645
Compare
9aac66b to
6f8744c
Compare
d2612a0 to
02d22ba
Compare
Member
|
Hi. I'm curious about the use of the C++ timers in here. Do you have thoughts on this, as to why they are being used, and what they are for? |
25f25e5 to
ff882c9
Compare
Contributor
Author
They're for collecting caching stats. |
ff882c9 to
5f4be20
Compare
Member
|
But they just give wall time, right? Wouldn't CPU performance registers or os time functions be more accurate? |
Contributor
Author
CPU performance registers and os time functions don't measure wall clock time, which is what I want here. |
02ef442 to
7a49e97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3138 +/- ##
===========================================
- Coverage 25.15% 25.13% -0.02%
===========================================
Files 149 150 +1
Lines 36969 36994 +25
Branches 7115 7116 +1
===========================================
- Hits 9297 9295 -2
- Misses 27672 27699 +27
|
7a49e97 to
105e30d
Compare
added 26 commits
February 18, 2025 14:26
should be removed in a future release.
tsk_img_open_utf8_cache_opt is now tsk_img_open_utf8_cache and doesn't take an options argument. (The cache will have been created with one.)
a450b71 to
c64b34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the legacy cache used by
TSK_IMG_INFOwith a cache that has O(1) insertion and lookup.