Update LoginValidator.java #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reshift has scanned for issues for the Pull-Request: 2 issue(s) found |
| String user=request.getParameter("username").trim(); | ||
| String pass=request.getParameter("password").trim(); | ||
|
|
||
| rs=stmt.executeQuery("select * from users where username='"+user+"' and password='"+pass+"'"); |
There was a problem hiding this comment.
Potential SQL Injection (JDBC) - CRITICAL
The input values included in SQL queries need to be passed in safely. Bind variables in prepared statements can be used to easily mitigate the risk of SQL injection.
| String user=request.getParameter("username").trim(); | ||
| String pass=request.getParameter("password").trim(); | ||
|
|
||
| rs=stmt.executeQuery("select * from users where username='"+user+"' and password='"+pass+"'"); |
There was a problem hiding this comment.
Potential SQL Injection (Non-constant String) - CRITICAL
The method invokes the execute or addBatch method on an SQL statement with a String that seems to be dynamically generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test sqli