-
Notifications
You must be signed in to change notification settings - Fork 115
feat: Migrate exercise to issue-based flow #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look again at the workflows in exercise-template
repository, especially what goes into check_step_work
and post_next_step_content
This documentation section may be helpful for check_step_work
@FidelusAleksander, I have implemented your suggestions and given it another test run. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first draft of the migration. I made some simple cleanup type changes across the files that you might not have thought to look at.
See my in-context comments for other feedback.
Finally, the main piece of feedback is to do a test run as the learner. I don't see any major changes to the contnet so it is likely very out of date. The easiest check is to do a trial run and assume you know very little. Walk through it and read it all word for word. Verify the pictures, button callouts, etc. are still accurate with github.com.
Note Publishing of these updates is delayed for business reasons. Current expectation is late July. If you would like to use the updated version, you are welcome to take the exercise from the unpublished version (skills-dev org). Just click on the source branch |
…low logic feat: add step to create comment with updated issue content fix: remove unnecessary GH_TOKEN variable from comment creation step fix: update comment creation step to use ISSUE_BODY variable for improved clarity fix: correct syntax for template-vars in comment creation step fix: streamline PR validation and disable workflow step fix: update response templates step and improve branch name check fix: enhance comment updates and error handling in workflow steps
…kflow steps fix: update commit validation steps and streamline PR checks fix: enhance validation steps for issue comments and streamline workflow dependencies
…ow checks fix: correct indentation for check_step_work job in workflow files fix: reorder checks for PR body and merge state in sidebar workflow fix: enhance failure condition to include PR merge state in workflow
feat: Migrate exercise to issue-based flow
Migration is on pause until further notice. |
Summary
This PR enhances the
connect-the-dots
skills exercise by converting it to an Issue-based flow, ensuring dynamic issue references, and improving workflow reliability and modularity. The changes support a scalable learner experience with better debugging and progression tracking.Changes
contents
,actions
, andissues
to enable workflow operations.STEP_1_FILE
,STEP_2_FILE
, ...,STEP_n_FILE
) as environment variable for consistent template referencing.start_exercise
job usingskills/exercise-toolkit/start-exercise.yml@v0.3.0
to initialize the exercise and output the issue URL.post_next_step_content
job to:actions/github-script@v7
._sidebar.md
updates and commit SHA storage.action-text-variables@v1
, using{{original_issue}}
and{{duplicate_issue}}
for dynamic referencing.{{original_issue}}
and{{duplicate_issue}}
dynamic, replacing hardcoded values to support multiple concurrent issue creations.gh workflow enable
find_exercise
job to locate the exercise issue usingskills/exercise-toolkit
.check_step_work
andverify_step_work
jobs to:actions/github-script@v7
for context debugging and output tracking.post_next_step_content
with dynamic content and workflow toggling.Closes: #94
Task list