Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

wolz-CODElife
Copy link

Summary

This PR enhances the connect-the-dots skills exercise by converting it to an Issue-based flow, ensuring dynamic issue references, and improving workflow reliability and modularity. The changes support a scalable learner experience with better debugging and progression tracking.

Changes

  • Set write permissions for contents, actions, and issues to enable workflow operations.
  • Defined the template files(STEP_1_FILE, STEP_2_FILE, ...,STEP_n_FILE) as environment variable for consistent template referencing.
  • Implemented start_exercise job using skills/exercise-toolkit/start-exercise.yml@v0.3.0 to initialize the exercise and output the issue URL.
  • Added post_next_step_content job to:
    • Create dynamic issues ("Fix the broken sidebar" and "Sidebar bug again") using actions/github-script@v7.
    • Prepare file history with _sidebar.md updates and commit SHA storage.
    • Build and post content with action-text-variables@v1, using {{original_issue}} and {{duplicate_issue}} for dynamic referencing.
    • Made issue identifiers {{original_issue}} and {{duplicate_issue}} dynamic, replacing hardcoded values to support multiple concurrent issue creations.
    • Change the navigation system to use: gh workflow enable
  • Added find_exercise job to locate the exercise issue using skills/exercise-toolkit.
  • Added check_step_work and verify_step_work jobs to:
    • Post "checking work" feedback and verify learner progress.
    • Use actions/github-script@v7 for context debugging and output tracking.
  • Enhanced post_next_step_content with dynamic content and workflow toggling.

Closes: #94

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look again at the workflows in exercise-template repository, especially what goes into check_step_work and post_next_step_content

This documentation section may be helpful for check_step_work

https://github.com/skills/skills-manager/blob/main/docs/2-design/design.md#step-grading-and-transition

.github/workflows/0-welcome.yml Show resolved Hide resolved
.github/workflows/0-welcome.yml Outdated Show resolved Hide resolved
.github/steps/1-resolve-duplicate-issues.md Outdated Show resolved Hide resolved
.github/steps/1-resolve-duplicate-issues.md Show resolved Hide resolved
.github/workflows/2-find-commit-in-history.yml Outdated Show resolved Hide resolved
.github/workflows/2-find-commit-in-history.yml Outdated Show resolved Hide resolved
.github/workflows/3-fix-broken-sidebar.yml Outdated Show resolved Hide resolved
@wolz-CODElife
Copy link
Author

@FidelusAleksander, I have implemented your suggestions and given it another test run.
Everything works fine:

image

image

@chriswblake chriswblake changed the title Migrate Skills Exercise from README -> Issue based flow feat: Migrate exercise to issue-based flow Jun 23, 2025
Copy link
Member

@chriswblake chriswblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first draft of the migration. I made some simple cleanup type changes across the files that you might not have thought to look at.

See my in-context comments for other feedback.

Finally, the main piece of feedback is to do a test run as the learner. I don't see any major changes to the contnet so it is likely very out of date. The easiest check is to do a trial run and assume you know very little. Walk through it and read it all word for word. Verify the pictures, button callouts, etc. are still accurate with github.com.

.github/steps/x-review.md Outdated Show resolved Hide resolved
.github/workflows/0-start-exercise.yml Outdated Show resolved Hide resolved
.github/workflows/0-start-exercise.yml Outdated Show resolved Hide resolved
.github/workflows/1-resolve-duplicate-issues.yml Outdated Show resolved Hide resolved
.github/workflows/1-resolve-duplicate-issues.yml Outdated Show resolved Hide resolved
.github/workflows/3-fix-broken-sidebar.yml Outdated Show resolved Hide resolved
.github/steps/1-resolve-duplicate-issues.md Outdated Show resolved Hide resolved
.github/steps/2-find-commit-in-history.md Outdated Show resolved Hide resolved
.github/steps/3-fix-broken-sidebar.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/0-start-exercise.yml Outdated Show resolved Hide resolved
.github/workflows/0-start-exercise.yml Outdated Show resolved Hide resolved
.github/workflows/0-start-exercise.yml Outdated Show resolved Hide resolved
.github/workflows/2-find-commit-in-history.yml Outdated Show resolved Hide resolved
@chriswblake chriswblake reopened this Jun 27, 2025
@chriswblake
Copy link
Member

Note

Publishing of these updates is delayed for business reasons. Current expectation is late July.

If you would like to use the updated version, you are welcome to take the exercise from the unpublished version (skills-dev org). Just click on the source branch skills-dev:main. We consider this update complete so nothing should change before launch.

…low logic

feat: add step to create comment with updated issue content

fix: remove unnecessary GH_TOKEN variable from comment creation step

fix: update comment creation step to use ISSUE_BODY variable for improved clarity

fix: correct syntax for template-vars in comment creation step

fix: streamline PR validation and disable workflow step

fix: update response templates step and improve branch name check

fix: enhance comment updates and error handling in workflow steps
…kflow steps

fix: update commit validation steps and streamline PR checks

fix: enhance validation steps for issue comments and streamline workflow dependencies
…ow checks

fix: correct indentation for check_step_work job in workflow files

fix: reorder checks for PR body and merge state in sidebar workflow

fix: enhance failure condition to include PR merge state in workflow
feat: Migrate exercise to issue-based flow
@chriswblake
Copy link
Member

Migration is on pause until further notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Migrate exercise to issue-based flow

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.