constructor m_client(MAX_SOCK_NUM) is not portable (fails to compile with UIPEthernet)#51
Merged
unwiredben merged 1 commit intosirleech:mastersirleech/Webduino:masterfrom Feb 28, 2014
ntruchsess:m_client_constructorntruchsess/Webduino:m_client_constructorCopy head branch name to clipboard
Merged
constructor m_client(MAX_SOCK_NUM) is not portable (fails to compile with UIPEthernet)#51unwiredben merged 1 commit intosirleech:mastersirleech/Webduino:masterfrom ntruchsess:m_client_constructorntruchsess/Webduino:m_client_constructorCopy head branch name to clipboard
unwiredben merged 1 commit intosirleech:mastersirleech/Webduino:masterfrom
ntruchsess:m_client_constructorntruchsess/Webduino:m_client_constructorCopy head branch name to clipboard
Conversation
…nt to EthernetClient() anyway
This was referenced Feb 28, 2014
use of undocumented (but public) constructor of EthernetClient(int)
milocreek/ArduinoConnectServer#1
Closed
unwiredben
added a commit
that referenced
this pull request
Feb 28, 2014
constructor m_client(MAX_SOCK_NUM) is not portable (fails to compile with UIPEthernet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the use of constructor EthernetClient(MAX_SOCK_NUM) breaks the compile when being used with UIPEthernet. Using the no-arg constructor has the same effect with Ethernet-library as it initializes _sock to MAX_SOCK_NUM anyway (https://github.com/arduino/Arduino/blob/master/libraries/Ethernet/EthernetClient.cpp#L17)