Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Specify in Gradle the minimum supported Java version#30

Merged
piotrrzysko merged 1 commit into
mainsimdjson/simdjson-java:mainfrom
java_version_fixsimdjson/simdjson-java:java_version_fixCopy head branch name to clipboard
Nov 12, 2023
Merged

Specify in Gradle the minimum supported Java version#30
piotrrzysko merged 1 commit into
mainsimdjson/simdjson-java:mainfrom
java_version_fixsimdjson/simdjson-java:java_version_fixCopy head branch name to clipboard

Conversation

@piotrrzysko

Copy link
Copy Markdown
Member

#29 introduced a set of GitHub actions testing the library against multiple Java versions. It turns out that this doesn't work as expected. The version specified in build.gradle is automatically downloaded when not available on a machine, thereby the JAVA_HOME environment variable is ignored. As a result, the Java versions provided by the GitHub actions aren't used. This PR should fix this issue.

@piotrrzysko piotrrzysko merged commit 6bd879c into main Nov 12, 2023
@piotrrzysko piotrrzysko deleted the java_version_fix branch November 12, 2023 16:29
Squiry pushed a commit to Squiry/simdjson-java that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.