Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

SG-37548 Add payload optimization on update method #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlos-villavicencio-adsk merged 11 commits into from
Feb 7, 2025
Merged

SG-37548 Add payload optimization on update method #363

carlos-villavicencio-adsk merged 11 commits into from
Feb 7, 2025

Conversation

@carlos-villavicencio-adsk
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Dec 20, 2024

Summary

This is a follow up work from #360 in this case including support for update method.

Affected methods

  • update

Detailed Description

The change should transform calls like:

sg.update(
    "Asset", 123,
    {
        "name": "Some name",
        "project": {
            "created_at": datetime.datetime(2015, 12, 16, 11, 2, 10, tzinfo),
            "id": 72,
            "name": "Demo: Game",
            "type": "Project",
        },
    },
)

as if the following had been called:

sg.update('Asset', 123, {'name': 'Some name', 'project' : {'id': 72, 'type': 'Project'}})

@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the base branch from master to ticket/SG-37544 December 20, 2024 13:33
@carlos-villavicencio-adsk carlos-villavicencio-adsk requested a review from a team December 20, 2024 13:34
eduardoChaucaGallegos
eduardoChaucaGallegos reviewed Dec 20, 2024
View reviewed changes
shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
julien-lang
julien-lang previously approved these changes Dec 20, 2024
View reviewed changes
Base automatically changed from ticket/SG-37544 to master January 28, 2025 19:59
@carlos-villavicencio-adsk carlos-villavicencio-adsk dismissed stale reviews from julien-lang and eduardoChaucaGallegos January 28, 2025 19:59

The base branch was changed.

julien-lang
julien-lang reviewed Jan 28, 2025
View reviewed changes
shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
tests/test_unit.py Outdated Show resolved Hide resolved
julien-lang
julien-lang reviewed Jan 29, 2025
View reviewed changes
shotgun_api3/shotgun.py Outdated Show resolved Hide resolved
@carlos-villavicencio-adsk @julien-lang
Update shotgun_api3/shotgun.py
b37fa34 
Co-authored-by: Julien Langlois <16244608+julien-lang@users.noreply.github.com>
eduardoChaucaGallegos
eduardoChaucaGallegos reviewed Jan 30, 2025
View reviewed changes
tests/test_unit.py Show resolved Hide resolved
@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit b83b9e2 into master Feb 7, 2025
24 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-37548 branch February 7, 2025 14:10
@carlos-villavicencio-adsk carlos-villavicencio-adsk mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-lang julien-lang julien-lang approved these changes

@eduardoChaucaGallegos eduardoChaucaGallegos eduardoChaucaGallegos approved these changes

Assignees

@carlos-villavicencio-adsk carlos-villavicencio-adsk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlos-villavicencio-adsk @julien-lang @eduardoChaucaGallegos
Morty Proxy This is a proxified and sanitized view of the page, visit original site.