Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@schworer
Copy link
Contributor

@schworer schworer commented Sep 1, 2010

If anyone is using less than Python 2.2, this patch will break them. However, inheriting from object allows us to use "new style class" features, like property getters and setters. Here's some more info:
http://docs.python.org/release/2.5.2/ref/node33.html

Also this gives me an excuse to try out the new pull request features.

--alex

@kporangehat
Copy link

Hey Alex,

Definitely not ignoring you here... thanks for this. We're a bit behind on things but will be focusing back on getting input very soon. The Shotgun Python API is only supported with Python 2.4, 2.5, and 2.6 at the moment officially. We'll support 3.0 eventually but won't go back before 2.4.

Anyway, thanks for this... hang tight.

@kporangehat
Copy link

Alex,

We just pushed this out as part of v3.0.4 (which also included a bug fix for an issue in the create() method that we introduced in v3.0.3). Thanks for the submission.

We're starting to work more closely on the API stuff so the turnarounds for pull requests should be quicker now (assuming they're things we're going to include of course). Thanks again!

@schworer
Copy link
Contributor Author

schworer commented Dec 1, 2010

Nice! Hope to get some more time to do some more work on the API.

plongitudes pushed a commit that referenced this pull request Apr 30, 2019
willis102 added a commit that referenced this pull request Aug 26, 2019
Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing this __init__ method, I noticed a potential improvement in the way URL validation is handled. The current approach checks base_url.split("/")[0] against "http:" and "https:", which can lead to incorrect results if the URL contains unexpected formatting or additional whitespace. A more robust approach would be to use Python’s urllib.parse module to properly parse and validate the scheme, ensuring the code works reliably for different URL formats. Additionally, it would be beneficial to add more descriptive docstrings explaining each parameter, especially convert_datetimes_to_utc and http_proxy, so that future maintainers understand their purpose and default behavior. Finally, initializing self.server to None is fine, but it might be worth documenting why it is deferred rather than set during initialization, to avoid confusion for other developers working with this class.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.