Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Hide shopware.yaml danger warning on config-schema.json change #13038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
Loading
from
Open

fix: Hide shopware.yaml danger warning on config-schema.json change #13038

wants to merge 2 commits into from
+1 −1

Conversation

gecolay
Copy link
Contributor

@gecolay gecolay commented Oct 16, 2025

1. Why is this change necessary?

2. What does this change do, exactly?

  • Hide shopware.yaml danger warning, if there is already a change in the config-schema.json file

3. Describe each step to reproduce the issue or behaviour.

  • Update shopware.yaml & config-schema.json files

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfilled them

@github-actions github-actions bot added external-contribution A PR contributed by a community member. milestone/6.7.4.0 labels Oct 16, 2025
@github-actions GitHub Actions
Copy link

Warnings
⚠️ The Pull Request doesn't contain any changelog file
Notice
📖 Any changes to .danger.php will not be reflected in your pull request. Commit your changes separately.

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.73%. Comparing base (e18a4bb) to head (d97330c).

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #13038   +/-   ##
=======================================
  Coverage   55.72%   55.73%           
=======================================
  Files        4908     4908           
  Lines      167148   167156    +8     
  Branches     9050     9050           
=======================================
+ Hits        93144    93161   +17     
+ Misses      71320    71309   -11     
- Partials     2684     2686    +2
Flag Coverage Δ
jest-admin 61.16% <ø> (+0.01%) ⬆️
jest-storefront 70.01% <ø> (ø)
phpunit-migration 49.31% <ø> (+0.05%) ⬆️
phpunit-unit 49.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the needs-triage A newly created issue or PR that needs team assignment and/or prioritization. label Oct 16, 2025
@mitelg mitelg self-assigned this Oct 16, 2025
@mitelg mitelg added domain/product-ops Responsible for Product Operations and removed needs-triage A newly created issue or PR that needs team assignment and/or prioritization. labels Oct 16, 2025
@mitelg mitelg requested a review from a team October 16, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitelg mitelg mitelg approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@mitelg mitelg

Labels

domain/product-ops Responsible for Product Operations external-contribution A PR contributed by a community member. milestone/6.7.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gecolay @mitelg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.