fix: improve select result list sometimes not loading the next page when scrolling to the bottom #13037
+72
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleifeld
approved these changes
Oct 17, 2025
mitelg
requested changes
Oct 17, 2025
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| title: Fix select result list not loading the next page | ||
| issue: NEXT-00000 |
There was a problem hiding this comment.
Suggested change
| issue: NEXT-00000 |
|
@janpetto would you mind having a look again? alternatively you can allow to make changes by us, then we can go on by ourselves 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The
sw-select-result-listcomponent is used in different select components and emits thepaginateevent whenever the user has scrolled to the bottom of the current options. Due to sub-pixel rendering and rounding differences across browsers, it can happen that the method to calculate the distance to the bottom returns a value slightly larger than 0, even when scrolled completely to the bottom. This will result in thesw-select-result-listcomponent to never emit thepaginateevent.2. What does this change do, exactly?
This change fixes the issue by rounding down the calculated difference to the bottom. If the distance to the bottom is less than one pixel, the list is considered to be scrolled to the bottom.
3. Describe each step to reproduce the issue or behaviour.
Many entity select fields do not load the next page when scrolling to the bottom of the result list. For example in the product filter of the order list page:
Screencast.from.2025-10-13.15-21-26.webm
4. Please link to the relevant issues (if any).
5. Checklist