fix: Paypal errors showing on category page (#12701) #13030
Draft
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #13030 +/- ##
==========================================
- Coverage 55.73% 55.72% -0.01%
==========================================
Files 4908 4908
Lines 167152 167147 -5
Branches 9050 9050
==========================================
- Hits 93154 93149 -5
- Misses 71313 71314 +1
+ Partials 2685 2684 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d4ffda5 to
f0a85d5
Compare
|
@namdinh-92 everything regarding the PayPal plugin has to live inside the PayPal Plugin - we don't fix issues with plugin specific code in platform itself |
Yes right, I rethink it for a while and arise another fix, revert this PR to be Draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
2. What does this change do, exactly?
storefront/resources/views/storefront/base.html.twigandstorefront/resources/views/storefront/page/checkout/_page.html.twigto make sure that the paypal errors only showing in checkout page, not showing on other pages.3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist