Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 35c5e1b

Browse filesBrowse files
committed
merged branch mvrhov/test_fixes (PR symfony#2357)
Commits ------- 395f580 Rebuild resource files with genrb from ICU 4.2. as ICU 4.4 by default builds them in newer format. Also added all files necessary to build resources.dat with pkgdat because syntax for command is so cryptic 438581d Skip test if running as superuser as it will fail Discussion ---------- Fixes failing tests This one closes both the symfony#2355 and symfony#2356
2 parents 3d64d8e + 395f580 commit 35c5e1b
Copy full SHA for 35c5e1b

File tree

7 files changed

+10
-0
lines changed
Filter options

7 files changed

+10
-0
lines changed

‎tests/Symfony/Tests/Component/HttpFoundation/File/MimeType/MimeTypeTest.php

Copy file name to clipboardExpand all lines: tests/Symfony/Tests/Component/HttpFoundation/File/MimeType/MimeTypeTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ public function testGuessWithNonReadablePath()
7979
$this->markTestSkipped('Can not verify chmod operations on Windows');
8080
}
8181

82+
if (in_array(get_current_user(), array('root'))) {
83+
$this->markTestSkipped('This test will fail if run under superuser');
84+
}
85+
8286
$path = __DIR__.'/../Fixtures/to_delete';
8387
touch($path);
8488
chmod($path, 0333);

‎tests/Symfony/Tests/Component/Translation/Loader/ResourceBundleLoaderTest.php

Copy file name to clipboardExpand all lines: tests/Symfony/Tests/Component/Translation/Loader/ResourceBundleLoaderTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ class ResourceBundleFileLoaderTest extends LocalizedTestCase
1919
{
2020
public function testLoad()
2121
{
22+
// resource is build using genrb command
2223
$loader = new ResourceBundleLoader();
2324
$resource = __DIR__.'/../fixtures/resourcebundle/res';
2425
$catalogue = $loader->load($resource, 'en', 'domain1');
@@ -30,6 +31,9 @@ public function testLoad()
3031

3132
public function testDatEnglishLoad()
3233
{
34+
// bundled resource is build using pkgdata command which at leas in ICU 4.2 comes in extremely! buggy form
35+
// you must specify an temporary build directory which is not the same as current directory and
36+
// MUST reside on the same partition. pkgdata -p resources -T /srv -d . packagelist.txt
3337
$loader = new ResourceBundleLoader();
3438
$resource = __DIR__.'/../fixtures/resourcebundle/dat/resources';
3539
$catalogue = $loader->load($resource, 'en', 'domain1');
Binary file not shown.
Binary file not shown.
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
en.res
2+
fr.res
Binary file not shown.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.