Fix options type for options.floatingUIOptions
#3011
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@patrikholcak is attempting to deploy a commit to the shipshapecode Team on Vercel. A member of the Team first needs to authorize it. |
|
@patrikholcak hitting this error: |
|
Yeah, that explains why it hasn’t been added in the first place 😄 I don’t like doing it, but would you be ok with me copying some of the declarations from floating ui (bad, I know) or should I look into the docs plugin? Maybe there’s an option to ignore a type or make it "external"? 🤷 I probably won’t have time over the weekend though |
Due to the way pnpm installs modules and how typescript declarations resolving works, typescript couldn’t be sure what the return type is. We can either specify the return value or cast (less safe)
|
@RobbieTheWagner it should be fixed now (works on my machine!) let me know if it does and I’ll either cherry-pick this into #3012 or wait for this to get merged and then just rebase/merge these changes into #3012 edit: The problem was due to how pnpm saves node modules and how typescript type resolving works (as far as I understand the issue) Here’s more info microsoft/TypeScript#58176 (comment) |
About
Shepherd is already using
ComputePositionConfiginternally in a few places, but the options object itself is typed asobject, which isn’t really helpful. Not sure if this is done because of some problem with docs — feel free to close this PR in that case!Proposed changes
Step.floatingUIOptions