Tshepo/f/kanban component #3206

Tshepo1103-lab · Apr 30, 2025

Summary by CodeRabbit

Refactor
- Updated import paths throughout the application for improved consistency and maintainability.
- Standardized the generation and assignment of unique IDs in the Kanban settings form for better clarity and consistency.
- Adjusted how Kanban columns are sourced, now deriving data from a provider hook instead of component props.
- Minor updates to UI component props for improved data handling.
- Improved formatting and structure of settings forms for enhanced readability.
- Renamed and reorganized internal provider components to align with new structure.
- Updated conditional rendering logic for Kanban placeholder display based on local state.
- Simplified action configurator label for clarity.
Chores
- Renamed and reorganized internal provider components to align with new structure.

…nceListDispatcher

coderabbitai · Apr 30, 2025

Walkthrough

This update primarily refactors import paths throughout the codebase, moving references from the @/providers/refList/provider and related modules to the new @/components/refListSelectorDisplay/provider location. Several files also update their modal and utility imports to reflect this new structure. In addition, the Kanban-related components now source their data from a provider hook rather than props, and the Kanban settings form introduces standardized unique IDs for UI elements using nanoid(). No exported APIs have changed, and no business logic was altered except for the data source adjustment in the Kanban component.

Changes

File(s)	Change Summary
`src/components/chevron/index.tsx` `src/components/kanban/components/renderColumn.tsx` `src/components/refListSelectorDisplay/options/configurator.tsx` `src/components/refListSelectorDisplay/provider/reducers.ts` `src/designer-components/chevron/chevron.tsx` `src/designer-components/chevron/settings.tsx` `src/designer-components/kanban/index.tsx` `src/designer-components/kanban/settings.tsx`	Updated import paths from `@/providers/refList/provider` and related modules to `@/components/refListSelectorDisplay/provider` and related modules. Adjusted modal and utility imports as well. No logic changes.
`src/components/kanban/index.tsx`	Changed the data source for columns: instead of using the `items` prop, the component now uses `items` from `useRefListItemGroupConfigurator`. Updated related state management and conditional rendering logic.
`src/components/refListSelectorDisplay/provider/index.tsx`	Renamed the provider internally to `RefListSelectorDisplayProvider` (re-exported under the original name). Replaced `useGet`/`refetch` with `getReferenceList` from `useReferenceListDispatcher`. Changed effect dependencies and logic to compare full `referenceList` objects.
`src/designer-components/inputComponent/index.tsx`	Modified the prop passed to `RefListItemSelectorSettingsModal` to use `referenceList` directly instead of `referenceList?._data`.
`src/designer-components/kanban/settingsForm.ts`	Standardized and explicitly generated unique IDs for all panels, rows, and inputs using `nanoid()`. Updated the "Data" tab to use `addSettingsInput` with `referenceListAutocomplete` type and a filter. No logic or validation changes.
`src/designer-components/chevron/settingsForm.ts`	Reformatted the `getSettings` function for improved readability and consistent style, including replacing array spread syntax with explicit arrays and consistent string quoting. Simplified the data tab input definition. No logic or control flow changes.

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent
    participant KanbanReactComponent
    participant useRefListItemGroupConfigurator (Provider)

    ParentComponent->>KanbanReactComponent: Render (no items prop)
    KanbanReactComponent->>useRefListItemGroupConfigurator: Call hook
    useRefListItemGroupConfigurator-->>KanbanReactComponent: Return { items, storeSettings }
    KanbanReactComponent->>KanbanReactComponent: Set columns state from items
    KanbanReactComponent->>ParentComponent: Render columns or placeholder based on columns state

Suggested reviewers

AlexStepantsov
James-Baloyi

Poem

In the warren where imports hop and play,
Paths were refactored, bright as day.
Kanban columns now fetch with cheer,
From providers new and near.
IDs sprout unique, like carrots in a row—
Code rabbits rejoice, for clarity does grow!
🥕✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3109ba and 9e071c8.

📒 Files selected for processing (1)

shesha-reactjs/src/components/refListSelectorDisplay/options/refListItemsSettingsForm.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

shesha-reactjs/src/components/refListSelectorDisplay/options/refListItemsSettingsForm.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build-attempt

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…work into tshepo/f/kanban-component

Tshepo1103-lab added 3 commits April 29, 2025 14:24

chore: moving the reflist to components

eb934ff

chore: channging the settings to use nanoid

d975ee9

chore: refactoring the fetch request for the reflist to use useRefere…

8c2ddff

…nceListDispatcher

Tshepo1103-lab added 5 commits April 30, 2025 15:18

Merge branch 'main' of https://github.com/Tshepo1103-lab/shesha-frame…

a8caf91

…work into tshepo/f/kanban-component

chore: channging the items to use from model

de74217

chore: changed to use the reflistAutocomplete on chevron

1d21848

chore: removing the space

f3109ba

Merge branch 'main' of https://github.com/Tshepo1103-lab/shesha-frame…

598f54e

…work into tshepo/f/kanban-component

Tshepo1103-lab marked this pull request as ready for review May 7, 2025 06:25

Tshepo1103-lab requested a review from AlexStepantsov May 7, 2025 08:51

chore: changing the property name to be more generic

9e071c8

AlexStepantsov approved these changes May 13, 2025

View reviewed changes

AlexStepantsov merged commit 3946eec into shesha-io:main May 13, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tshepo/f/kanban component #3206

Tshepo/f/kanban component #3206

Uh oh!

Tshepo1103-lab commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

Tshepo/f/kanban component #3206

Tshepo/f/kanban component #3206

Uh oh!

Conversation

Tshepo1103-lab commented Apr 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Tshepo1103-lab commented Apr 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)