Add the i flag to grep

shelljs · nfischer · Jul 23, 2018 · Jul 19, 2018 · Jul 20, 2018 · Jul 20, 2018
commit 734e287802186f61ba7082f0aa5756df51a04709
diff --git a/README.md b/README.md
@@ -362,7 +362,8 @@ include the base directories (e.g., `lib/resources/file1` instead of just `file1
 Available options:

 + `-v`: Invert `regex_filter` (only print non-matching lines).
-+ `-l`: Print only filenames of matching files
+ `-l`: Print only filenames of matching files.
+ `-i`: Ignore case.

 Examples:


diff --git a/src/grep.js b/src/grep.js
@@ -19,7 +19,7 @@ common.register('grep', _grep, {
 //@
 //@ + `-v`: Invert `regex_filter` (only print non-matching lines).
 //@ + `-l`: Print only filenames of matching files.
-//@ + `-i`: Ignored upper/lower case differences.
+//@ + `-i`: Ignore case.
 //@
 //@ Examples:
 //@

diff --git a/test/grep.js b/test/grep.js
@@ -137,6 +137,13 @@ test('-l option', t => {
  t.is(result.split('\n').length - 1, 2);
 });

+test('-i option', t => {
+  const result = shell.grep('-i', 'test', 'test/resources/case1', 'test/resources/case1.txt',
+    'test/resources/case1.js');
+  t.falsy(shell.error());
+  t.is(result.split('\n').length - 1, 3);
+});
+
 test('the pattern looks like an option', t => {
  const result = shell.grep('--', '-v', 'test/resources/grep/file2');
  t.falsy(shell.error());

diff --git a/test/resources/case1 b/test/resources/case1
@@ -0,0 +1 @@
+Test3
diff --git a/test/resources/case1.js b/test/resources/case1.js
@@ -0,0 +1 @@
+test3
diff --git a/test/resources/case1.txt b/test/resources/case1.txt
@@ -0,0 +1 @@
+TEST3
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Test3
Copy link Member nfischer Jul 20, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. This is OK, but could you move these files under `test/resources/grep/case1`? That should fix the other failures. Copy link Contributor Author ppsleep* Jul 21, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. OK, I moved it, and sorry for my thoughtless actions.