fix(grep, sed, sort, uniq): Split only on newline characters #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
- Coverage 94.67% 94.67% -0.01%
==========================================
Files 33 33
Lines 1183 1182 -1
==========================================
- Hits 1120 1119 -1
Misses 63 63
Continue to review full report at Codecov.
|
|
@freitagbr can you see what the issue is with code coverage? If we're uncovering any lines, we should see if we can add tests. |
|
The diff is +7/-9, so overall -2, so the coverage is going to decrease. No lines are becoming uncovered. |
nfischer
approved these changes
Mar 15, 2017
|
I think it could be breaking. Just to be safe, let's change the target branch to dev so this can land in v0.8. |
36e7e66 to
4caabf1
Compare
freitagbr
added a commit
that referenced
this pull request
Jun 7, 2017
* Split on newlines only * Only split lines if need be * Clarify code by making use of Array.prototype.reduce
Merged
nfischer
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Split on newlines only * Only split lines if need be * Clarify code by making use of Array.prototype.reduce
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits and joins on newlines only.
Fixes #645 .