Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

nfischer
Copy link
Member

Fixes #647

@nfischer nfischer added the chore label Jan 17, 2017
@nfischer nfischer requested a review from freitagbr January 17, 2017 01:01
@nfischer nfischer added the breaking Breaking change label Jan 17, 2017
Copy link
Contributor

@freitagbr freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should leave a note in the README that starting with v0.8, we are only supporting Node v4+? Also, is everything on dev slated for v0.8?

@nfischer
Copy link
Member Author

@freitagbr I updated the README to mention v4+. I don't think it's necessary to mention this corresponds with v0.8, since that'll be the version once we merge dev into master.

@nfischer
Copy link
Member Author

And yes, dev branch contains changes for v0.8. Once we get close to a release, we can merge into master and do the finishing touches on the master branch. Postponing the merge is helpful, otherwise v0.8 docs will show up on the README before it's released.

@freitagbr
Copy link
Contributor

LGTM, needs a rebase off of dev though.

@nfischer
Copy link
Member Author

Updated with Github UI. Should be fine, since it all squashes anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.