Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

mperrando
Copy link
Contributor

Actually find does not go inside a symlink that is a folder.

In order to preserve old behaviour, the -L flag has been introduced to modify the behaviour and enter symlink'ed folders.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems reasonable overall

test/find.js Show resolved Hide resolved
@nfischer nfischer added bash compat Compatibility issues with bash or POSIX behavior feature labels Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1080 (d22bb03) into master (4b6b17a) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
- Coverage   97.19%   96.38%   -0.82%     
==========================================
  Files          36       36              
  Lines        1354     1354              
==========================================
- Hits         1316     1305      -11     
- Misses         38       49      +11     
Impacted Files Coverage Δ
src/find.js 95.45% <100.00%> (-4.55%) ⬇️
src/which.js 80.00% <0.00%> (-15.00%) ⬇️
src/cmd.js 94.11% <0.00%> (-5.89%) ⬇️
src/ln.js 96.87% <0.00%> (-3.13%) ⬇️
src/ls.js 97.67% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6b17a...d22bb03. Read the comment docs.

@nfischer nfischer merged commit 8c926df into shelljs:master Feb 25, 2022
@nfischer nfischer added this to the v0.9.0 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash compat Compatibility issues with bash or POSIX behavior feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.