Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Merge 'exec: internal error' with ShellJSInternalError #734

Copy link
Copy link
@nfischer

Description

@nfischer
Issue body actions

I can't actually remember why we have both ShellJSInternalError and exec: internal error, but they mean the same thing: there's a bug in ShellJS code somewhere. These should probably get merged together, so that we can actually keep the exception stack for bugs in exec. This would help immensely in debugging.

While it's true that exec() sometimes crashes unavoidably (like if we overrun the max buffer), it's definitely still helpful to have the stack trace, and it still makes sense to report it as an exception, instead of with shell.error() (that should be reserved for the external command's stderr).

kstratis and g-ongenae

Metadata

Metadata

Assignees

Labels

execIssues specific to the shell.exec() APIIssues specific to the shell.exec() APIstability

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.