Support absolute path in exclude #1609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
requested changes
Aug 30, 2024
| .map(|p| { | ||
| let path = Path::new(p); | ||
| let relative_path = if path.is_absolute() { | ||
| let cwd = env::current_dir().unwrap_or("".into()); |
There was a problem hiding this comment.
This won't work if one or more search paths is given to fd, since it needs to be relative to the search path, which may not be the current directory.
| .exclude | ||
| .iter() | ||
| .map(|p| { | ||
| let path = Path::new(p); |
There was a problem hiding this comment.
It isn't a path, it's a pattern.
What if there is a glob that occurs between the root and the search path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1577