Add WSL2 support for hyperlinks #1608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we can copy how ripgrep does it? https://github.com/BurntSushi/ripgrep/blob/ea99421ec896fcc9a9cd5367d42a80f89316822f/crates/core/flags/hiargs.rs#L1384-L1406 |
|
Yeah you're right, that is definitely a better way of doing it. It also seems that ripgrep automatically detects common terminals and uses their specific schemes, seems like something that might be worth looking into hmm EDIT: Seems like I was mistaken, looks like they don't do any checks like that and just let the user choose a format if they want to have one. VS Code's integrated terminal in my case just does this on its own I guess, they do bundle it for their own search iirc so makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the hyperlinks generated by fd don't quite work inside wsl2 as you have to use a very specific hostname in this case.
Thankfully as far as I'm aware every officially supported wsl2 distro comes with the
wslpathutility that can quickly convert between windows and wsl paths so getting the hostname is as easy as calling that with the root of the file system as an argument.Performance wise this shouldn't cause any issues, since it only runs once regardless of how many files are being printed. Other unix environments should be unaffected by this, since it'll just silently fail and use
gethostnameas usual.