for review of vsphere advanced capabilities by DaanHoogland · Pull Request #56 · shapeblue/cloudstack

DaanHoogland · May 28, 2020

Description

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java

DaanHoogland · Jul 2, 2020

plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java

        return true;
    }

+    //TODO: Remove this method after deploying VM from OVF directly using content library


on second thought, we need to be backwards compatible. I don't think we can do this with a single transition script.

DaanHoogland

thanks Suresh, i'll start a build to deploy and test tomorrow

DaanHoogland · Jul 2, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/ContentLibraryHelper.java

+        createSpec.setDescription("Local content library for datastore " + datastoreName);
+        createSpec.setType(LibraryModel.LibraryType.LOCAL);
+        createSpec.setStorageBackings(Collections.singletonList(storageBacking));
+


sounds like a method should be create called buildTheSpecificationForTheLibraryToBeCreated(...)

DaanHoogland · Jul 2, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/ContentLibraryHelper.java

+        //Get the storage backing on the datastore
+        StorageBacking dsStorageBacking = createStorageBacking(context, datastoreName);
+        boolean canDelete = false;
+        for (Iterator<StorageBacking> iterator = localLibrary.getStorageBackings().iterator(); iterator.hasNext();) {
+            StorageBacking storageBacking = (StorageBacking) iterator.next();
+            if(dsStorageBacking.equals(storageBacking)) {
+                canDelete = true;
+                break;
+            }
+        }


getTheStorageBackingOnTheDatastore(...)

DaanHoogland · Jul 2, 2020

@sureshanaparti please don't force push on a shared branch. We can clean up before a public PR.

DaanHoogland · Jul 7, 2020

.../main/java/org/apache/cloudstack/api/command/admin/zone/ImportVsphereStoragePoliciesCmd.java

+        authorized = {RoleType.Admin})
+public class ImportVsphereStoragePoliciesCmd extends BaseCmd {
+
+    public static final Logger s_logger = Logger.getLogger(ImportVsphereStoragePoliciesCmd.class.getName());


@harikrishna-patnala , can you make this static final Logger LOGGER?

DaanHoogland · Jul 7, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java


+    /**
+     * deploys a new VM from a ovf spec. It ignores network, defaults locale to 'US'
+     * @param host


@DaanHoogland (note to self) remove un-annotated annotation tags

DaanHoogland · Jul 7, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/PbmPlacementSolverMO.java

+
+public class PbmPlacementSolverMO extends BaseMO {
+
+    private static final Logger s_logger = Logger.getLogger(PbmPlacementSolverMO.class);


statis final naming

DaanHoogland · Jul 7, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/PbmProfileManagerMO.java

+
+public class PbmProfileManagerMO extends BaseMO {
+
+    private static final Logger s_logger = Logger.getLogger(PbmProfileManagerMO.class);


statis final naming

DaanHoogland · Jul 7, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualStorageObjectManagerMO.java

+
+public class VirtualStorageObjectManagerMO extends BaseMO {
+    @SuppressWarnings("unused")
+    private static final Logger s_logger = Logger.getLogger(VirtualStorageObjectManagerMO.class);


statis final naming

DaanHoogland · Jul 7, 2020

vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/ContentLibraryClient.java

+import com.vmware.vcenter.ovf.LibraryItem;
+
+public class ContentLibraryClient implements VmwareClientService {
+    private static final Logger s_logger = Logger.getLogger(ContentLibraryClient.class);


statis final naming

yadvr · Jul 8, 2020

@harikrishna-patnala @DaanHoogland can you merge latest master and address the conflicts. I'll start some test/review work in 2 hrs. Thnx.

…bm sdk

…ragePolicies API is called multiple times

…he disk offering. Added corresponding manager objects from PBM sdk to do the job. Made dao layer changes to read the storage policy in diskoffering

…the cluster into CloudStack Setting scope is still pending.

…ools inside the datastore cluster

…ot the children in the Datastore cluster

…e storage pool with tags, cancelling mantenance mode and deleting storage pool

…e type

DaanHoogland · Jul 28, 2020

engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql

+INSERT IGNORE INTO `cloud`.`disk_offering` (name, uuid, display_text, customized, unique_name, disk_size, system_use, type, display_offering)
+VALUES ('Custom Deploy-as-is Instance', UUID(), 'Custom Deploy-as-is Instance', 1, 'ApacheCloudStack.org-Custom Deploy-as-is Instance', 0, 0, 'Service', 0);
 INSERT IGNORE INTO `cloud`.`service_offering` (`id`, `nw_rate`, `mc_rate`) VALUES
-((SELECT `id` FROM `cloud`.`disk_offering` WHERE `unique_name` = 'Cloud.com-Custom Deploy-as-is Instance'), null, null);
+((SELECT `id` FROM `cloud`.`disk_offering` WHERE `unique_name` = 'ApacheCloudStack.org-Custom Deploy-as-is Instance'), null, null);


@shwstppr this change will let you select the custom offering to use as a quick fix.

UUID as generated in the diskoffering

uniquename = ApacheCloudStack.org-Custom Deploy-as-is Instance

DaanHoogland · Jul 29, 2020

engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

+            Answer answer = new Answer(null);
+            CopyCommandResult result = new CopyCommandResult(null, null);
+            result.setSuccess(true);
+            caller.complete(result);


I must say this is a terrible hack, maybe we should rename the method to reflect that the copy may not even be attempted?

[VMWare] error when detaching volume (apache#6283)

DaanHoogland force-pushed the vsphereAdvancedCapabilities branch from 50e8709 to de099c0 Compare June 12, 2020 10:46

DaanHoogland commented Jul 2, 2020

View reviewed changes

plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java Outdated Show resolved Hide resolved

DaanHoogland commented Jul 2, 2020

View reviewed changes

sureshanaparti force-pushed the vsphereAdvancedCapabilities branch from 14b90b0 to 15cdd27 Compare July 2, 2020 14:18

DaanHoogland commented Jul 2, 2020

View reviewed changes

sureshanaparti force-pushed the vsphereAdvancedCapabilities branch from eef8701 to a268d94 Compare July 2, 2020 20:18

DaanHoogland commented Jul 7, 2020

View reviewed changes

harikrishna-patnala and others added 16 commits July 8, 2020 07:45

Initial commit adding few required managed object classes and added p…

66c019f

…bm sdk

Added PBM service connect

76c183b

pokemon anihilation and class-javadoc

1db6d78

Fix root folder issue on datastore

32aa580

add ovf properties to template details

f2ea28c

disected ova processing

8311a54

import

4772813

Added importVsphereStoragePolicies API and scheme changes

50678db

Fixed bean creation errors on VsphereStoragePolicyDaoImpl

b27735d

Added Storage policy id to VO

78ec211

Moved Dao and VO files to different packages

8f10d32

Added gen_toc.py changes for API importvpsherestoragepolicies

dfe20e4

Fixed unit test failure

0e3f72c

Updated code to handle sync of storage policies when importVsphereSto…

c7c4dc8

…ragePolicies API is called multiple times

Check if datastore is complaince with the storagepolicy provided in t…

957924d

…he disk offering. Added corresponding manager objects from PBM sdk to do the job. Made dao layer changes to read the storage policy in diskoffering

ovf string props hack

0b98d26

nvazquez and others added 18 commits July 23, 2020 09:20

Remove unused disks size template detail

40928f3

Persist trimmed hardware items keys

ee5e70f

Process CPU and memory configurations from OVF

4ada1ea

Remove spaces from hardware items

ccaf63c

Add Datastore cluster and the child entities which are datastores in …

b305414

…the cluster into CloudStack Setting scope is still pending.

Register Disk to first class disk whereever possible

2a86c5c

Allocation logic to skip datastore cluster and consider only storagep…

813b6b6

…ools inside the datastore cluster

Handle datastore clusters in list storage pools to list only parent n…

e0541ac

…ot the children in the Datastore cluster

Fix adding Datastore clusters and listing

93f9953

Datastore Clusters operations on putting into maintenance mode, updat…

3efc0aa

…e storage pool with tags, cancelling mantenance mode and deleting storage pool

Fix NPE on one of the register disk usecases

b7e8c2f

Datastore cluster: update tag to the child storagepools also

e73308e

Generalise linked clone formats which are different for each datastor…

c509a2d

…e type

nic allocation refactor

b5df79d

Fix immutable list to add another entry to list

51379b8

factor out removal of old VM

4947e5d

Add default custom offering for deploy as is templates

500fa0d

inter-cluster migration support

d5453ba

Pearl1594 force-pushed the vsphereAdvancedCapabilities branch from 62c82d8 to d5453ba Compare July 28, 2020 08:17

Daan Hoogland added 2 commits July 28, 2020 13:00

minor cleanup

2ada555

adjust service offering to be available for selection in vApps

2fa988f

DaanHoogland commented Jul 28, 2020

View reviewed changes

Daan Hoogland and others added 3 commits July 28, 2020 15:03

column width for 'unique_name' at least as much as for 'name'

3b5a07c

Fix add diskTOs to VM spec again

571ddf6

Fix Vm start - disks mapping in progress

1ee3cb8

DaanHoogland commented Jul 29, 2020

View reviewed changes

nvazquez added 2 commits July 29, 2020 10:56

Fix GB size bug when registering template

a277cef

Fix volumes missing path and chain info

78690aa

DaanHoogland closed this Oct 27, 2020

shwstppr pushed a commit that referenced this pull request Sep 22, 2022

Merge pull request #56 from shapeblue/sb10-ammendment

f9262b6

[VMWare] error when detaching volume (apache#6283)


		public class PbmPlacementSolverMO extends BaseMO {

		private static final Logger s_logger = Logger.getLogger(PbmPlacementSolverMO.class);


		public class PbmProfileManagerMO extends BaseMO {

		private static final Logger s_logger = Logger.getLogger(PbmProfileManagerMO.class);

Search code, repositories, users, issues, pull requests...

Conversation

DaanHoogland commented May 28, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 2, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jul 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants