[Misc]add static library .a in gitignore #281
Conversation
Summary of ChangesHello @pallasathena92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a rule to .gitignore to exclude static libraries (.a files), which is a good practice for preventing build artifacts from being checked into the repository. My review includes a suggestion to also ignore dynamic library files (.so, .dylib) that can be generated by the project's build process, making the change more comprehensive.
| # static library | ||
| *.a |
There was a problem hiding this comment.
While adding *.a to ignore static libraries is a good step, the build configuration in pkg/xet/Cargo.toml (with crate-type = ["staticlib", "cdylib"]) and scripts in pkg/xet/Makefile indicate that dynamic libraries (.so, .dylib) are also generated as build artifacts. To ensure all build artifacts are ignored, I recommend adding patterns for these files as well.
# static and dynamic libraries
*.a
*.so
*.dylib
What this PR does / why we need it:
This static library created by local build, it don't need to upload in repo.
Does this PR introduce a user-facing change?
None.