Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rename songs array to audio array in Config#504

Copy link
Copy link
@danpastori

Description

@danpastori
Issue body actions

Discussed in #503

Originally posted by danpastori May 4, 2022

馃憠 Describe the problem

Right now you add audio to the AmplitudeJS configuration through a songs array. This doesn't make sense if you are working with audio files that aren't songs such as podcasts.

馃懃 Problem evidence & reach

Any user that works with podcasts, interviews, etc.

馃グ Describe the "impact" on users?

It's more developer friendly to name the songs array as audio if the user is working with audio files that aren't songs (i.e podcasts).

馃弳 How to solve this problem

Rename the songs array to audio and update all references within the code. This will be a breaking change from 5.3 -> 6.0 but will document it.

馃挴 How do we validate the problem is solved?

Users can semantically set audio instead of songs within AmplitudeJS making it more inline with their use case.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Ready for QA
Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.