Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 15, 2019

Fixes #4069

  • Removes unconditional tab completion setup from postinstall script
  • Configure serverless config tabcompletion install and serverless config tabcompletion uninstall commands
  • Configure interactlive CLI completion setup step
  • Update to v3 of tabtab which has significantly improved setup (pollution of .bashrc and similar config is minimal, there's no setup made in project local node_modules, which was quite error-prone and couldn't work reliably with linked setup)

As tabtab requires Node.js v8 and non Windows environment, all configured functionalities are presented to user only if user environment supports them.

Additionally:

  • Fix providers handling in config plugin. While it seemed to enable, not configured locally, spotinst provider, it was still rejected from list (due to .slice(-1) calls).
    In pursued fix, I didn't enable spotinst though, as I believe that should be achieved in context of a plugin and not hard-coded here.
  • Reconfigured lib/plugins/config.test.js to rely on @serverless/test/run-serverless.js

@medikoo medikoo added this to the 1.55.0 milestone Oct 15, 2019
@medikoo medikoo self-assigned this Oct 15, 2019
@medikoo medikoo force-pushed the move-autocomplete-to-interactive-cli branch from 851f335 to 3df964e Compare October 15, 2019 15:17
@medikoo medikoo requested a review from pmuens October 16, 2019 09:58
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked thoroughly through the code and couldn't find anything.

I haven't tested it on my machine, though. Feel free to merge if you think it's GTM :shipit:

@medikoo medikoo merged commit 69972e5 into master Oct 17, 2019
@medikoo medikoo deleted the move-autocomplete-to-interactive-cli branch October 17, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add separate command for completion install/uninstall (was: npm install mucks with preferences silently)

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.