-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Setup <tab> completion via CLI command and interactive CLI step #6835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was by mistaked added with #4127 Such list should be extended in capacity of a plugin
851f335 to
3df964e
Compare
pmuens
approved these changes
Oct 17, 2019
Contributor
pmuens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked thoroughly through the code and couldn't find anything.
I haven't tested it on my machine, though. Feel free to merge if you think it's GTM ![]()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4069
serverless config tabcompletion installandserverless config tabcompletion uninstallcommandstabtabwhich has significantly improved setup (pollution of.bashrcand similar config is minimal, there's no setup made in project localnode_modules, which was quite error-prone and couldn't work reliably with linked setup)As
tabtabrequires Node.js v8 and non Windows environment, all configured functionalities are presented to user only if user environment supports them.Additionally:
configplugin. While it seemed to enable, not configured locally,spotinstprovider, it was still rejected from list (due to.slice(-1)calls).In pursued fix, I didn't enable
spotinstthough, as I believe that should be achieved in context of a plugin and not hard-coded here.lib/plugins/config.test.jsto rely on@serverless/test/run-serverless.js