feat(AWS Schedule): Support groupName for scheduler method #12357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2024
bartelemi
approved these changes
Feb 16, 2024
|
Closing this since it does not seem like the maintainers are going to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12319
Allows users to specify a schedule group for schedule events with method
schedulerin AWS.For convenience, we could create a schedule group, if none with the given name exists, rather than relying on the user to create one as a resource. Since I believe the common use case is to have more than one schedule in the same group, referring to the group as
!Ref SchedulerGroupshould be preferred and that is cleaner when users define the group themselves.