Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@bwind
Copy link
Contributor

@bwind bwind commented Nov 20, 2019

Fixes #131

Short description of what this PR does:

setup.py includes all packages (containing an init.py) using find_packages(). This is a problem because it will include the tests directory as a top level importable module in the local app, breaking our own tests that happen to live in a directory with the same name.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 20, 2019
@SendGridDX
Copy link

SendGridDX commented Nov 20, 2019

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious changed the title Exclude tests directory from package data fix: Exclude tests directory from package data Feb 19, 2020
@thinkingserious thinkingserious merged commit 50a24aa into sendgrid:master Feb 19, 2020
childish-sambino pushed a commit to tysonholub/python-http-client that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py includes tests directory in package data

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.