Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

For Macintosh, Brand is None #71

Copy link
Copy link
Closed
@gitclem

Description

@gitclem
Issue body actions

I have verified that this is still true.

In the example on https://github.com/ua-parser/uap-python/blob/master/README.rst

It seems that "Macintosh" should be result in a brand of "Apple". Model or family should be "Macintosh".

>>> from ua_parser import user_agent_parser
>>> import pprint
>>> pp = pprint.PrettyPrinter(indent=4)
>>> ua_string = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.104 Safari/537.36'
>>> parsed_string = user_agent_parser.ParseDevice(ua_string)
>>> pp.pprint(parsed_string)
{   'brand': None,
    'family': 'Other',
    'model': None}

In addition, iPad hardware isn't tagged either:

>>> ua_sring = "Mozilla/5.0 iPad CPU OS 9_2_1 like Mac OS X AppleWebKit/601.1.46 KHTML like Gecko Mobile/13D15 Safari/601.1.46 Sleipnir/4.2.2m"
>>> parsed_string = user_agent_parser.ParseDevice(ua_string)
>>> pp.pprint(parsed_string)
{   'brand': None, 'family': 'Other', 'model': None}

PLPeeters and will-gao42

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.