Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8745b25

Browse filesBrowse files
committed
Adding Chromebook detection as a "pc"
1 parent 8c3c05c commit 8745b25
Copy full SHA for 8745b25

File tree

Expand file treeCollapse file tree

2 files changed

+5
-0
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-0
lines changed

‎user_agents/parsers.py

Copy file name to clipboardExpand all lines: user_agents/parsers.py
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,8 @@ def is_pc(self):
231231
# Maemo has 'Linux' and 'X11' in UA, but it is not for PC
232232
if 'Maemo' in self.ua_string:
233233
return False
234+
if 'CrOS' in self.ua_string:
235+
return True
234236
if 'Linux' in self.ua_string and 'X11' in self.ua_string:
235237
return True
236238
return False

‎user_agents/tests.py

Copy file name to clipboardExpand all lines: user_agents/tests.py
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
android_firefox_aurora_ua_string = 'Mozilla/5.0 (Android; Mobile; rv:27.0) Gecko/27.0 Firefox/27.0'
3131
thunderbird_ua_string = 'Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 Lightning/4.0.2'
3232
outlook_usa_string = 'Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Trident/6.0; Microsoft Outlook 15.0.4420)'
33+
chromebook_ua_string = 'Mozilla/5.0 (X11; CrOS i686 0.12.433) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.77 Safari/534.30'
3334

3435
iphone_ua = parse(iphone_ua_string)
3536
ipad_ua = parse(ipad_ua_string)
@@ -54,6 +55,7 @@
5455
android_firefox_aurora_ua = parse(android_firefox_aurora_ua_string)
5556
thunderbird_ua = parse(thunderbird_ua_string)
5657
outlook_ua = parse(outlook_usa_string)
58+
chromebook_ua = parse(chromebook_ua_string)
5759

5860

5961
class UserAgentsTest(unittest.TestCase):
@@ -165,6 +167,7 @@ def test_is_pc(self):
165167
self.assertTrue(ie_touch_ua.is_pc)
166168
self.assertTrue(ie_ua.is_pc)
167169
self.assertFalse(android_firefox_aurora_ua.is_pc)
170+
self.assertTrue(chromebook_ua.is_pc)
168171

169172
def test_is_bot(self):
170173
self.assertTrue(google_bot_ua.is_bot)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.