Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add missing licenses for SBOM workflow #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

o1oo11oo
Copy link
Contributor

@o1oo11oo o1oo11oo commented Oct 6, 2023

Description

Because the license check was added after the pipeline for the SBOM workflow succeeded, the files added by the pull request were not checked before the request was merged to main. Some of them were missing license information, which gets added with this.

Closes #2010

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Because the license check was added after the pipeline for the SBOM
workflow succeeded, the files added by the pull request were not checked
before the request was merged to main. Some of them were missing license
information, which gets added with this.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
@o1oo11oo o1oo11oo added the bug Bugs label Oct 6, 2023
@o1oo11oo o1oo11oo self-assigned this Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit bf98748
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/651fbeef98ab6f0008cfda21

@o1oo11oo o1oo11oo requested a review from Weltraumschaf October 6, 2023 11:50
@Weltraumschaf Weltraumschaf merged commit 5fb2ca2 into secureCodeBox:main Oct 6, 2023
@o1oo11oo o1oo11oo deleted the fix/missing-licenses branch October 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

License check fails due to SBOM workflow files
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.