-
Notifications
You must be signed in to change notification settings - Fork 163
Fix helm unit test templates #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Weltraumschaf
merged 6 commits into
secureCodeBox:main
from
o1oo11oo:fix/helm-pipeline-azure-monitor
Oct 4, 2023
Merged
Fix helm unit test templates #2008
Weltraumschaf
merged 6 commits into
secureCodeBox:main
from
o1oo11oo:fix/helm-pipeline-azure-monitor
Oct 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-securecodebox canceled.
|
Merged
The check is also broken currently, so to fix the one pipeline blocker disable the other one for now. Will get reverted later. Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
The azure monitor snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Weltraumschaf
approved these changes
Oct 4, 2023
The defectdojo snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
fd442c7
to
4eb9a09
Compare
The elastic hook snapshot for the tests was mising the tolerations and affinity fields for some reason, which made the tests fail. Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Some juiceshop details changed, which needs to be updated in the test snapshots as well. Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Weltraumschaf
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a hint in the commit message, why a change fixes something. Makes review easier, if not deep into topic.
I thought I had put some details at least in most commits, now it's a bit late to change them though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The helm unit tests fail for multiple charts, because the templates don't match anymore, this updates them to match again.
This temporarily disables the license check, which is also broken, will be fixed (and reenabled) by #2006.
Closes #2007
Checklist