Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix helm unit test templates #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

o1oo11oo
Copy link
Contributor

@o1oo11oo o1oo11oo commented Oct 4, 2023

Description

The helm unit tests fail for multiple charts, because the templates don't match anymore, this updates them to match again.

This temporarily disables the license check, which is also broken, will be fixed (and reenabled) by #2006.

Closes #2007

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit d1f4955
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/651d583844a56e00088b1bbd

@o1oo11oo o1oo11oo requested a review from Weltraumschaf October 4, 2023 11:48
@o1oo11oo o1oo11oo self-assigned this Oct 4, 2023
@o1oo11oo o1oo11oo added the bug Bugs label Oct 4, 2023
@o1oo11oo o1oo11oo mentioned this pull request Oct 4, 2023
Lukas Fischer added 2 commits October 4, 2023 13:50
The check is also broken currently, so to fix the one pipeline blocker
disable the other one for now. Will get reverted later.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
The azure monitor snapshot for the tests was mising the tolerations and
affinity fields for some reason, which made the tests fail.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
@Weltraumschaf Weltraumschaf enabled auto-merge (rebase) October 4, 2023 11:51
The defectdojo snapshot for the tests was mising the tolerations and
affinity fields for some reason, which made the tests fail.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
@o1oo11oo o1oo11oo force-pushed the fix/helm-pipeline-azure-monitor branch from fd442c7 to 4eb9a09 Compare October 4, 2023 11:59
Lukas Fischer added 3 commits October 4, 2023 14:06
The elastic hook snapshot for the tests was mising the tolerations and
affinity fields for some reason, which made the tests fail.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Some juiceshop details changed, which needs to be updated in the test
snapshots as well.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
@o1oo11oo o1oo11oo changed the title Fix azure monitor helm test Fix helm unit test templates Oct 4, 2023
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a hint in the commit message, why a change fixes something. Makes review easier, if not deep into topic.

@Weltraumschaf Weltraumschaf merged commit 5a9ab16 into secureCodeBox:main Oct 4, 2023
@o1oo11oo
Copy link
Contributor Author

o1oo11oo commented Oct 4, 2023

I thought I had put some details at least in most commits, now it's a bit late to change them though.

@o1oo11oo o1oo11oo deleted the fix/helm-pipeline-azure-monitor branch October 4, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Pipeline fails due to helm snapshot mismatches
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.