Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Find attempted questions by difficulty #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

juhitiwari
Copy link
Contributor

@juhitiwari juhitiwari commented Dec 18, 2020

The new changes, find out the number of checked questions and group them by difficulty. Currently, it is just printing on the dev console and not on the UI. But if the logic seems correct we can go forward with that afterward.
Steps:
Firstly find the number of checked questions from the local storage and find their difficulty level and store them in a dictionary
Initialize this as our state
Then on every check box state change, we increment the corresponding difficulty value (or decrement it if check box in unchecked)
Issues #39 and #59 correspond to this.

@seanprashad
Copy link
Owner

Hey @juhitiwari - thank again for getting this patch started. I'm testing it locally and it looks great but I ran into an error:

image

I'm still digging around but I'll let you know of any updates we'll need to add!

@juhitiwari
Copy link
Contributor Author

Hey @seanprashad, I am not able to reproduce this at my end :( It gives the correct results:
Screenshot from 2020-12-26 01-04-27
Do let me know if there's a way I can look at it from my side and if there are any updates.

@seanprashad
Copy link
Owner

Hey @seanprashad, I am not able to reproduce this at my end :( It gives the correct results:
Screenshot from 2020-12-26 01-04-27
Do let me know if there's a way I can look at it from my side and if there are any updates.

Will do! I'm testing things over on the debug-checkedQuestionsByDifficulty branch - will report back later!

Copy link
Owner

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the error after starting fresh - might just be a one-off thing! Let's land this patch and maybe we can discuss what a potential update to the UI would look like!

Amazing work once again @juhitiwari!! 🎉

@seanprashad seanprashad merged commit 82cf595 into seanprashad:master Dec 25, 2020
seanprashad pushed a commit that referenced this pull request Dec 25, 2020
An existing quesiton already has the ID of 173 and this was causing some
problems when attempting to update the difficulty counter, which landed
in #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.