Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Better paging #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025
Merged

Better paging #193

merged 7 commits into from
May 6, 2025

Conversation

adespawn
Copy link
Collaborator

This PR introduces:

  • paging in client.execute()
  • isPaged query option
  • setting pageState in result set.

This PR doesn't introduce:

  • optimizations of paging
  • ability to use async iterator over result set

@adespawn
Copy link
Collaborator Author

Why is this failing js doc...

@adespawn adespawn marked this pull request as ready for review April 28, 2025 09:28
@adespawn adespawn requested a review from wprzytula April 28, 2025 09:35
@wprzytula wprzytula added this to the Iteration 2 milestone Apr 28, 2025
lib/types/result-set.js Outdated Show resolved Hide resolved
lib/types/result-set.js Outdated Show resolved Hide resolved
lib/types/result-set.js Show resolved Hide resolved
lib/client.js Show resolved Hide resolved
adespawn added 7 commits May 6, 2025 13:06
Remove already done TODO from query options
Add option that decides wether the query should be paged or not.
In order to be compatible with the DataStax driver,
default value for this option is true.
In the driver, user can provide page state as a buffer.
Allow conversion of this buffer into PagingState(Wrapper)
that is used by the Rust driver
Set pageState and rawPageState in the result set,
based on the page state returned by the rust driver
Add ability to execute paged and unpaged queries,
through client.execute() endpoint, based on isPaged option.
@adespawn adespawn merged commit 9d6f476 into second-iteration May 6, 2025
8 checks passed
@adespawn adespawn deleted the better-paging branch May 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.