-
Notifications
You must be signed in to change notification settings - Fork 1
Minor changes #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change the <code>
tags to backticks, exchange also the other HTML tags to their markdown equivalents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/client.js:47
- Consider verifying that the type 'clientOptions.ClientOptions' is consistent with the rest of the project's naming conventions. If the change is intentional, ensure that the corresponding import and usage match the updated type.
* @param {clientOptions.ClientOptions} options The options for this instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain why you decided to use `` insted of `
Why would I need to explain valid MD syntax? |
5712c85
to
6f4c9e6
Compare
Because it's contrary to the code-wide convention. Every project I've seen, especially ScyllaDB's, uses single backticks. |
f000daa
to
1cc09b7
Compare
f048cb6
to
5e438d8
Compare
util.isDate was deprecated in Node 23 https://nodejs.org/api/deprecations.html#DEP0047
Some of the js-doc types weren't correctly recognized. This fixes this problem.
Updated placement of rustyExecute and executePromise.
and replace them with markdown paragraphs.
This PR includes few minor changes related to code style and documentation