Minor changes #177
Merged
Minor changes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ZuzaOsa
requested changes
Apr 7, 2025
ZuzaOsa
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/client.js:47
- Consider verifying that the type 'clientOptions.ClientOptions' is consistent with the rest of the project's naming conventions. If the change is intentional, ensure that the corresponding import and usage match the updated type.
* @param {clientOptions.ClientOptions} options The options for this instance.
PiotrJunior
reviewed
Apr 15, 2025
Why would I need to explain valid MD syntax? |
5712c85 to
6f4c9e6
Compare
Because it's contrary to the code-wide convention. Every project I've seen, especially ScyllaDB's, uses single backticks. |
f000daa to
1cc09b7
Compare
f048cb6 to
5e438d8
Compare
ZuzaOsa
approved these changes
Apr 29, 2025
util.isDate was deprecated in Node 23 https://nodejs.org/api/deprecations.html#DEP0047
Some of the js-doc types weren't correctly recognized. This fixes this problem.
Updated placement of rustyExecute and executePromise.
and replace them with markdown paragraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes few minor changes related to code style and documentation