Buffer as values

EDIT: After some investigation, it appears any value can be provided as buffer, empty or not

add support so that test: should support retrieving empty buffers as values passes

scylladb-javascript-driver/test/integration/not-supported/client-execute-tests.js

Lines 131 to 168 in bad25f7

    
           it("should support retrieving empty buffers as values", () => { 
        
               // Include some columns to make sure the behaviour is consistent across different types. 
        
               // Inserting empty buffers fails server side for some types, e.g., "Not enough bytes to read a list" 
        
               const columnsAsNulls = [ 
        
                   "bigint_sample", 
        
                   "int_sample", 
        
                   "double_sample", 
        
                   "timeuuid_sample", 
        
               ]; 
        
               const columns = ["text_sample", "blob_sample"].concat( 
        
                   columnsAsNulls, 
        
               ); 
        
               const insertQuery = 
        
                   `INSERT INTO ${table} (id, ${columns.join(",")})` + 
        
                   ` VALUES (?, ${columns.map(() => "?").join(",")})`; 
        
               const selectQuery = `SELECT * FROM ${table} WHERE id = ?`; 
        
               const emptyBuffer = utils.allocBufferUnsafe(0); 
        
               const id = types.Uuid.random(); 
        
               const client = setupInfo.client; 
        
               return client 
        
                   .execute( 
        
                       insertQuery, 
        
                       [id].concat(columns.map(() => emptyBuffer)), 
        
                   ) 
        
                   .then(() => client.execute(selectQuery, [id])) 
        
                   .then((rs) => { 
        
                       const row = rs.first(); 
        
                       columnsAsNulls.forEach((c) => 
        
                           assert.strictEqual(row[c], null), 
        
                       ); 
        
                       assert.strictEqual(row["text_sample"], ""); 
        
                       assert.deepStrictEqual( 
        
                           row["blob_sample"], 
        
                           utils.allocBufferUnsafe(0), 
        
                       ); 
        
                   }); 
        
           });

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buffer as values #89

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	it("should support retrieving empty buffers as values", () => {
	// Include some columns to make sure the behaviour is consistent across different types.
	// Inserting empty buffers fails server side for some types, e.g., "Not enough bytes to read a list"
	const columnsAsNulls = [
	"bigint_sample",
	"int_sample",
	"double_sample",
	"timeuuid_sample",
	];
	const columns = ["text_sample", "blob_sample"].concat(
	columnsAsNulls,
	);
	const insertQuery =
	`INSERT INTO ${table} (id, ${columns.join(",")})` +
	` VALUES (?, ${columns.map(() => "?").join(",")})`;
	const selectQuery = `SELECT * FROM ${table} WHERE id = ?`;
	const emptyBuffer = utils.allocBufferUnsafe(0);
	const id = types.Uuid.random();
	const client = setupInfo.client;

	return client
	.execute(
	insertQuery,
	[id].concat(columns.map(() => emptyBuffer)),
	)
	.then(() => client.execute(selectQuery, [id]))
	.then((rs) => {
	const row = rs.first();
	columnsAsNulls.forEach((c) =>
	assert.strictEqual(row[c], null),
	);
	assert.strictEqual(row["text_sample"], "");
	assert.deepStrictEqual(
	row["blob_sample"],
	utils.allocBufferUnsafe(0),
	);
	});
	});

Search code, repositories, users, issues, pull requests...

Buffer as values #89

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions