Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Memory bugs #221

Copy link
Copy link
@adespawn

Description

@adespawn
Issue body actions

NAPI-RS had a use after free bug, when calling async functions with vector of references (Vec<&Element>) as an argument. This issue was reported and then fixed, but the changes were applied to NAPI-RS in version 3 only. This means, that at this moment we still are using version containing this bug.

The possible appearances of this issue are:

memory allocation of ??? bytes failed
thread 'tokio-runtime-worker' panicked at library/alloc/src/slice.rs:161:25:
capacity overflow

Currently, we tried worked around this issue, by trying to stop concurrency, but this appeared to only reduce the probability of the issue appearing.

We can avoid this issue entirely, by not using Vec<&Element> in async functions (example of those changes were introduced in #183)

Metadata

Metadata

Assignees

No one assigned

    Labels

    externalClosing of this issue would require changes to external librariesClosing of this issue would require changes to external libraries

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.