Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@adamralph
Copy link
Contributor

The defect https://scan8.coverity.com:8443/reports.htm#v21582/p10801/fileInstanceId=3240428&defectInstanceId=1396798&mergedDefectId=96018 found by Coverity is actually a false positive since the locking was not in place to give public thread safety but only to guarantee correct implementation, given the internal timer thread, but reading the code, it was difficult to tell. I considered suppressing the warning but then I realised making the type threadsafe was actually a trivial change and removes ambiguity for the reader so I thought to go down that route instead.

khellang added a commit that referenced this pull request Jan 3, 2015
@khellang khellang merged commit 4b0687e into scriptcs:dev Jan 3, 2015
@khellang khellang added this to the v0.13 milestone Jan 3, 2015
@adamralph adamralph deleted the refactor-file-watcher branch January 4, 2015 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.