ScriptPacks acceptance test #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
_Fails on TravisCI_ 😢 |
Member
|
This also contains the commit from #796... |
Contributor
Author
|
Yep, this one is on hold (see label). I was just experimenting and I wanted to have the proper error coming out of the installation step. Now that the other PR is merged I'll rebase and continue. At the moment, however, I'm not seeing a path out of the failure on Mono. |
Contributor
Author
|
I have a suspicion it might be the absolute path to the local gallery for the script pack installation, i.e. |
Member
|
Well that didn't work 😝 |
Contributor
Author
|
Rebased, but still need to fix things for the Mono build. |
Contributor
Author
|
Success at last! This is good to go now. |
Member
|
Awesome job @adamralph 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #720