Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Wechat oauth2 support #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zuoc wants to merge 4 commits into from
Closed

Add Wechat oauth2 support #821

zuoc wants to merge 4 commits into from

Conversation

@zuoc
Copy link

@zuoc zuoc commented Feb 4, 2018 •
edited
Loading

Hello!

I add Wechat(http://www.wechat.com/) support.

You can complete the test through the https://mp.weixin.qq.com/debug/cgi-bin/sandbox?t=sandbox/login.

Before that, you need to set up a server to receive WeChat‘s messages.

Here's the golang code I used to build the test server

package main

import (
	"net/http"
	"log"
	"io"
)

func main() {
	http.HandleFunc("/message", func(w http.ResponseWriter, r *http.Request) {
		r.ParseForm()
		log.Println(r.Form)
		io.WriteString(w, r.Form.Get("echostr"))
	})

	http.HandleFunc("/callback", func(w http.ResponseWriter, r *http.Request) {
		r.ParseForm()
		log.Println(r.Form)
	})

	log.Fatal(http.ListenAndServe(":8088", nil))
}

@zuoc
Copy link
Author

zuoc commented Feb 22, 2018

Hi.
What's the problem in this pull request?

@kullfar
Copy link
Member

kullfar commented Feb 22, 2018

Hi, it's ok, just a lack of time. I'll get it soon

@zuoc
Copy link
Author

zuoc commented Feb 23, 2018

ok，thanks

@kullfar
Copy link
Member

kullfar commented Mar 29, 2018

Hi, for the moment, it's hard to run the example.
First of all I need test application credentials - client_id and client_secret.
And then possibility to login somehow, so I need test user credentials.

This link https://mp.weixin.qq.com/debug/cgi-bin/sandbox?t=sandbox/login didn't help me. I can't register new apps and users. It's too time expensive for me, sorry.

There was the same problem with WeChat in this PR
#739

@zuoc
Copy link
Author

zuoc commented Mar 30, 2018

You can visit http://www.wechat.com/ first, download the app and register an account.

Then visit https://mp.weixin.qq.com/debug/cgi-bin/sandbox?t=sandbox/login and login to the test platform using the above registered account

@kullfar
Copy link
Member

kullfar commented Apr 2, 2018

Sorry, I can't register the account and/or app. It's time consuming task for me (c) https://github.com/scribejava/scribejava/wiki/FAQ#when-will-you-support-insert_api_here-

@zuoc zuoc closed this Apr 5, 2018
@Addvilz
Copy link

Addvilz commented Apr 13, 2019

Any chance this PR could be resurrected? WeChat is way larger auth provider than many of the ones already implemented (1b+ users).

@kullfar
Copy link
Member

kullfar commented Apr 15, 2019

why not? I'm still in lack of any credentials to test the changes.
As I remember last time registration on wechat just didn't work.
If someone can provide test app's and test user's credentials, it will be great chance to merge this or another Pull Request with WeChat functionality

@Addvilz
Copy link

Addvilz commented Apr 15, 2019

Funny as it is, I just tried, seems like WeChat international account registration has been suspended...

Unless there is someone based in mainland China who can provide a test account, this is unlikely to succeed. Pity.

@kullfar
Copy link
Member

kullfar commented Apr 15, 2019

And as I remember, it was impossible to login from outside of China even if you have login+password. There were a lot of additional questions.
I think, if WeChat is a cool company, they should provide "test user" functionality as Facebook does.

@kullfar
Copy link
Member

kullfar commented Apr 15, 2019

Anyway, it's quite easy to use your own 1 class with API (in some cases a couple) and ScribeJava as dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zuoc @kullfar @Addvilz
Morty Proxy This is a proxified and sanitized view of the page, visit original site.