-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added Frappe.io OAuth2 API #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @Override | ||
| public Verb getAccessTokenVerb() { | ||
| return Verb.POST; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to override this method. It's POST by default
|
The main question is "How can I test this Pull Request?". I need FrappeExample.java and app/user credentials to successfully run it. |
|
Login with (Role - System Manager) I'll delete above credentials after testing. Client Details Added in Example, Login and change client details here https://scribejava.mntechnique.com/desk#Form/OAuth%20Client/37763ecdb0 In this case serverURL keeps changing as per the hosting domain name. For others who wish to use their own frappe server url, I can think of extending FrappeApi to CustomFrappeApi and using it instead. I've added setter and getter for this. Any thing better you can suggest? e.g. References : Frappe Framework is Open Source Web App Framework |
|
great work, well done. |
OAuth 2 API for apps made with Frappe Framework https://frappe.io