Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Deprecate Request#setConnectionKeepAlive() #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wldaunfr wants to merge 3 commits into from
Closed

Deprecate Request#setConnectionKeepAlive() #521

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7c173c
Remove Request#setConnectionKeepAlive()
wldaunfr Nov 19, 2014
a79166f
Add deprecated Request#setConnectionKeepAlive()
wldaunfr Nov 19, 2014
7e15c2d
Concise Javadoc for Request#setConnectionKeepAlive()
wldaunfr Nov 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions 10 src/main/java/org/scribe/model/Request.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public class Request
private HttpURLConnection connection;
private String charset;
private byte[] bytePayload = null;
private boolean connectionKeepAlive = false;
private boolean followRedirects = true;
private Long connectTimeout = null;
private Long readTimeout = null;
Expand Down Expand Up @@ -81,7 +80,6 @@ private void createConnection() throws IOException
String completeUrl = getCompleteUrl();
if (connection == null)
{
System.setProperty("http.keepAlive", connectionKeepAlive ? "true" : "false");
connection = (HttpURLConnection) new URL(completeUrl).openConnection();
connection.setInstanceFollowRedirects(followRedirects);
}
Expand Down Expand Up @@ -353,13 +351,15 @@ public void setCharset(String charsetName)
/**
* Sets whether the underlying Http Connection is persistent or not.
*
* @deprecated does nothing - JVM default is left untouched.
* Set {@code http.keepAlive} system property to {@code false} for pre-deprecation behavior.
*
* @see http://download.oracle.com/javase/1.5.0/docs/guide/net/http-keepalive.html
* @param connectionKeepAlive
*/
@Deprecated
public void setConnectionKeepAlive(boolean connectionKeepAlive)
{
this.connectionKeepAlive = connectionKeepAlive;
}
{}

/**
* Sets whether the underlying Http Connection follows redirects or not.
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.